[PY] Implement logical expected conditions in Python #7406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GQAssurance
force-pushed
the
python-logical-ecs
branch
from
02ca4cf to
c170625
Compare
GQAssurance
changed the title
GQAssurance
force-pushed
the
python-logical-ecs
branch
from
c170625 to
f025061
Compare
GQAssurance
changed the title
isaulv
reviewed
Jul 28, 2019
| result = expected_condition(driver) | ||
| if not result: | ||
| return False | ||
| return True |
There was a problem hiding this comment.
return True should be outside the for loop.
Many expected conditions sometimes return the element or object you're waiting for.
Should this return a list of all results?
There was a problem hiding this comment.
(1) (facepalm) fixed
(2) That's a good idea. the all_of function now returns every EC's result in a list; it could then be parsed for elemental results if needed.
Replicates the functionality of Java's AND / OR / NOT expected conditions. Because of reserved word constraints in Python, these are named: OR: `any_of(*expected_condition)` AND: `all_of(*expected_condition)` NOT: `none_of(*expected_condition)` Each function takes an unlimited number of expected_conditions as arguments. Implements SeleniumHQ#7121
GQAssurance
force-pushed
the
python-logical-ecs
branch
from
f025061 to
ead2a2c
Compare
|
LGTM. |
1 task
Is there any way I can help get this merged into master? |
AutomatedTester
approved these changes
Aug 28, 2019
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replicates the functionality of Java's AND / OR / NOT expected conditions.
Because of reserved word constraints in Python, these are named:
OR:
any_of(*expected_condition)AND:
all_of(*expected_condition)NOT:
none_of(*expected_condition)Each function takes an unlimited number of expected_conditions as arguments.
Implements #7121
Xin the preceding checkbox, I verify that I have signed the Contributor License Agreement